Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alert Table enhancements #42

Merged
merged 4 commits into from
Apr 29, 2024
Merged

Alert Table enhancements #42

merged 4 commits into from
Apr 29, 2024

Conversation

roshni73
Copy link
Collaborator

@roshni73 roshni73 commented Apr 24, 2024 •
edited
Loading

Addresses:

Changes

  • Add table count value
  • Make table sent column sortable
  • Fix the admin1 list

This PR doesn't introduce:

  • typos
  • conflict markers
  • unwanted comments
  • temporary files, auto-generated files or secret keys
  • console.log meant for debugging
  • codegen errors

@roshni73 roshni73 requested a review from barshathakuri April 24, 2024 10:14
@roshni73 roshni73 requested a review from samshara April 25, 2024 04:20
@barshathakuri barshathakuri marked this pull request as draft April 26, 2024 03:56
@roshni73 roshni73 requested a review from barshathakuri April 26, 2024 11:18
@samshara samshara marked this pull request as ready for review April 26, 2024 11:23
samshara
samshara requested changes Apr 26, 2024
View reviewed changes
src/views/Home/AlertsTable/index.tsx Outdated Show resolved Hide resolved
@samshara samshara changed the title Fix/alert table Alert Table enhancements Apr 26, 2024
samshara
samshara requested changes Apr 29, 2024
View reviewed changes
Copy link
Member

@samshara samshara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is not working right now. It's causing AlertsTable to crash. Let's fix all the errors.

@samshara samshara merged commit 1ee716e into develop Apr 29, 2024
4 checks passed
@samshara samshara deleted the fix/alert-table branch April 29, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samshara samshara samshara approved these changes

@barshathakuri barshathakuri Awaiting requested review from barshathakuri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roshni73 @samshara @barshathakuri